This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
TxTypes for web3.js Ext #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohkwak
requested review from
kjeom,
JayChoi1736 and
blukat29
as code owners
blukat29
reviewed
Sep 16, 2023
web3js-ext/src/web3/klaytn_tx.ts
Outdated
Comment on lines
126
to
127
| // @ts-ignore | ||
| this.key = txData.key; |
There was a problem hiding this comment.
Define 'key' in KlaytnTxData type at L10, then remove ts-ignore.
web3js-ext/src/web3/klaytn_tx.ts
Outdated
|
|
||
| // A readonly CoreKlaytnTx object | ||
| this.klaytnTxData = KlaytnTxFactory.fromObject({ | ||
| let initTxData = { |
web3js-ext/src/web3/klaytn_tx.ts
Outdated
| key: this.key, | ||
| }; | ||
|
|
||
| if ( txData.type == 0x28 ) { |
There was a problem hiding this comment.
Use the TxType enum please
blukat29
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The Partial FeeDelegation part was completed more easily than I expected, so it was added.)